[IGNITE-4026] BinaryObjectBuilder.build() can fail if one of the fields is Externalizable

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.7
• Fix Version/s: 1.8
• Component/s: binary
• Assignee: Vladimir Ozerov
• Reporter: Valentin Kulichenko
• Created: 04/Oct/16 20:35
• Updated: 05/Apr/17 11:37
• Resolved: 02/Dec/16 10:03

Description

Test reproducing the issue is attached.

Scenario is the following:

1. Create a binary object with an Externalizable field.
2. Create a builder from this object using toBuilder() method.
3. Do some modifications.
4. Call build(), get exception below.

Exception in thread "main" class org.apache.ignite.binary.BinaryObjectException: Invalid flag value: -2
	at org.apache.ignite.internal.binary.builder.BinaryBuilderReader.parseValue(BinaryBuilderReader.java:761)
	at org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl.serializeTo(BinaryObjectBuilderImpl.java:281)
	at org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl.build(BinaryObjectBuilderImpl.java:183)
	at BuilderTest.main(BuilderTest.java:16)

Similar issue exists with enums. An attempt to set enum field to builder with a value which was read from a binary object fails with this exception:

Exception in thread "main" class org.apache.ignite.binary.BinaryObjectException: Wrong value has been set [typeName=MyType, fieldName=enum, fieldType=Enum, assignedValueType=Object]
	at org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl.checkMetadata(BinaryObjectBuilderImpl.java:401)
	at org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl.serializeTo(BinaryObjectBuilderImpl.java:316)
	at org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl.build(BinaryObjectBuilderImpl.java:183)
	at BuilderTest2.main(BuilderTest2.java:15)

The letter is reproduced in BinaryTest2.java (attached).

Issue Links

• is duplicated by: IGNITE-4312 DML: update causes IgniteCheckedException: Invalid flag value: -2
• relates to: IGNITE-4917 BinaryObjectBuilder field value access failed if its serialized with optimal marshaller
• links to: GitHub Pull Request #1289