[IGNITE-3828] Data streamer: use identity comparison for "activeKeys" in DataStreamerImpl.load0 method.

• Type: Task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.7
• Fix Version/s: 1.8
• Component/s: streaming
• Labels: performance
• Assignee: Andrey Mashenkov
• Reporter: Vladimir Ozerov
• Created: 02/Sep/16 15:13
• Updated: 12/Sep/16 08:26
• Resolved: 09/Sep/16 10:10

Description

See DataStreamerImpl.load0 method. One of it's arguments is activeKeys collection. Elements from this collection is removed when batch is successfully applied on the server. Currently this collections is concurrent hash set of KeyCacheObject. In case hash conflict occurs (which is not unusual for streaming when lots of keys are loaded), it leads to full byte-by-byte comparison of binary objects. It might be very inefficient.

To avoid the problem we should wrap KeyCacheObject into additional class with overridden equals and hashCode methods, so equality check is performed only through reference equality (==). This way hash conflicts will be resolved extremely fast.

Issue Links

• links to: GitHub Pull Request #1034