Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-3323

Get rid of copypasted JB annotations, use dependency instead.

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5.0.final
    • Fix Version/s: 1.7
    • Component/s: None
    • Labels:

      Description

      From user request:

      I've come across an issue where there are a couple of classes duplicated from org.jetbrains.annotations within the ignite-core module which conflict with other part of our code base.

      As these files are duplicated rather than being referenced as a maven dependency I am unable to exclude them or reference a specific version of the org.jetbrains.annotations artifact.

      Specifically, the included version cannot be used to annotate types
      ignite-core-1.6.0.jar:org.jetbrains.annotations.Nullable ...
      @Target(

      Unknown macro: {ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, ElementType.LOCAL_VARIABLE}

      )
      annotations-15.0.jar:org.jetbrains.annotations.Nullable ...
      @Target(

      Unknown macro: {ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, ElementType.LOCAL_VARIABLE, ElementType.TYPE_USE}

      )

      As far as I know there isn't an easy way of excluding these files from within the ignite-core module. Is there are reason why these "external" files have been duplicated within the ignite code base rather than being referenced as a maven dependency? Or alternatively, has anyone come across a way of avoiding these conflicts?

      Seems we have to remove these classes from Ignite code and use maven dependency.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                thehoff Jens Hoffmann
                Reporter:
                avinogradov Anton Vinogradov
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: