[IGNITE-21098] Increase additional wait after DDL by MaxClockSkew

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0
• Labels: ignite-3
• Assignee: Roman Puchkovskiy
• Reporter: Roman Puchkovskiy
• Reviewer: Sergey Chugunov
• Created: 16/Dec/23 07:36
• Updated: 04/Sep/24 16:08
• Resolved: 19/Dec/23 08:45

Description

When executing an RO transaction, readTimestamp has to be determined. If MaxObservableTimestamp is not available (which is currently true after a DDL), then TxManagerImpl takes readTimestamp as HLC.now() - idleSafeTimePropagationPeriod - MaxClockSkew.

In IGNITE-20668, an additional wait after a DDL operation was added to make sure that a readTimestamp calculated in this way does not look before the DDL (otherwise, the RO would see the previous schema). But in IGNITE-20668, only idleSafeTimePropagationPeriod was added after a DDL, and MaxClockSkew component was forgotten.

We must add MaxClockSkew to the wait.

Issue Links

• is related to: IGNITE-20668 Increase wait after a DDL to account for idle safe-time propagation period
• is related to: IGNITE-21084 Account for differences of logical part of now() on different nodes when waiting after a DDL
• links to: GitHub Pull Request #2963