[IGNITE-19110] Cleanup CompletableFutureMatcher

• Type: Task
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 3.0.0-beta2
• Labels: ignite-3
• Assignee: Aleksandr Polovtsev
• Reporter: Aleksandr Polovtsev
• Reviewer: Kirill Tkalenko
• Created: 23/Mar/23 13:15
• Updated: 23/Mar/23 15:21
• Resolved: 23/Mar/23 15:21

Description

CompletableFutureMatcher was originally intended to match successful outcomes of a future. For checking that a future has failed, there exists a CompletableFutureExceptionMatcher. For some reason, though, CompletableFutureMatcher was extended to match exceptional outcomes as well, which makes the code ugly. Also, let's compare the diagnostic messages they provide:

assertThat(failedFuture(new IllegalArgumentException()), CompletableFutureMatcher.willFailFast(NullPointerException.class))

This matcher produces the following result:

org.opentest4j.AssertionFailedError: 
Expected :true
Actual   :false

assertThat(failedFuture(new IllegalArgumentException()), CompletableFutureExceptionMatcher.willThrow(NullPointerException.class));

This matcher produces the following result:

java.lang.AssertionError: 
Expected: a future that completes with an exception that is an instance of java.lang.NullPointerException
     but: was completed exceptionally with <java.lang.IllegalArgumentException>
Expected :a future that completes with an exception that is an instance of java.lang.NullPointerException
Actual   :completed exceptionally with <java.lang.IllegalArgumentException>

I propose to remove the exception checking part from CompletableFutureMatcher and replace it with CompletableFutureExceptionMatcher.

Issue Links

• links to: GitHub Pull Request #1835