[IGNITE-16763] TableManager doesn't throw exception on table create, if something goes wrong in configuration listener for updateAssignments

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Labels: ignite-3
• Epic Link: Local state recovery
• Assignee: Unassigned
• Reporter: Denis Chudov
• Created: 29/Mar/22 17:55
• Updated: 26/Sep/23 13:58

Description

Scenario:

Start a node, try to create a table. Inside of TableManager the listener onTableCreate is successfully executed. Then, an exception happens inside of TableManager#onUpdateAssignments

configuration listener, which is triggered after the completion of onTableCreate listener. To reproduce the issue need to add an exception throwing in TableManager#onUpdateAssignments and create a table.

Expected behavior:

There is no operational instance of the newly created table on the node that initiated creation of the table, because onUpdateAssignments had failed. "Create table" operation should fail with exception.

Actual:

"Create table" operation succeeds, as onTableCreate listener in TableManager had  succeeded.

Suggested fix:

onUpdateAssignments should save exception to versioned values in TableManager, as it updates these versioned values. Thus, the following VersionedValue#get will throw an exception, and table creation future will be completed exceptionally (see TableManager#completeApiCreateFuture ). However, we should think about how further updates of these versioned values will happen.

Issue Links

• is part of: IGNITE-16862 Add ability to complete VersionedValue with exception