[IGNITE-16256] ItInternalTableScanTest.testMultipleRowScan is flaky

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha4
• Labels: ignite-3
• Assignee: Alexander Lapin
• Reporter: Alexander Lapin
• Reviewer: Vladislav Pyatkov
• Created: 11/Jan/22 09:20
• Updated: 04/Nov/22 10:56
• Resolved: 12/Jan/22 07:24

Description

org.opentest4j.AssertionFailedError: More data is not expected. ==> expected: <true> but was: <false>     at org.apache.ignite.distributed.ItInternalTableScanTest.requestNtest(ItInternalTableScanTest.java:592)     at org.apache.ignite.distributed.ItInternalTableScanTest.testMultipleRowScan(ItInternalTableScanTest.java:248) 

 Test seems to be incorrect because there's a race between submitting all data to retrievedItems list and calling Subscriber.onComplete(). In other words instead of

    @Override
    public void onComplete() {
        noMoreData.set(true);
    }
});

assertTrue(waitForCondition(() -> retrievedItems.size() == submittedItems.size(), 2_000));

assertTrue(noMoreData.get(), "More data is not expected."); 

following should be used:

    @Override
    public void onComplete() {
        subscriberAllDataAwaitLatch.countDown();
    }
});

subscriberAllDataAwaitLatch.await();

assertEquals(submittedItems.size(), retrievedItems.size()); 

Issue Links

• links to: GitHub Pull Request #541