Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-16117

Thin 3.0: Convert async exceptions in sync APIs

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.0.0-alpha3
    • 3.0.0-alpha4
    • thin client

    Description

      Currently, synchronous APIs delegate to async variants like this:

          public Collection<R> deleteAllExact(@NotNull Collection<R> recs) {
              return deleteAllExactAsync(recs).join();
          }
      

      However, join() throws CompletionException so users have to unwrap the actual exception manually.

      Implement exception unwrapping in all synchronous client APIs. See how server-side APIs deal with this in AbstractTableView#sync.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            ptupitsyn Pavel Tupitsyn
            ptupitsyn Pavel Tupitsyn
            Igor Sapego Igor Sapego
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 10m
                10m

                Slack

                  Issue deployment