[IGNITE-15921] Vulnerability in thin client protocol leads to OOM

• Type: Improvement
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.11
• Fix Version/s: 2.13
• Component/s: thin client
• Labels: ise ise.lts
• Release Note: Fixed potential OOM in thin client protocol handler caused by malicious or garbage data.
• Ignite Flags: Docs Required, Release Notes Required
• Assignee: Pavel Tupitsyn
• Reporter: Ilya Kazakov
• Reviewer: Igor Sapego
• Created: 16/Nov/21 03:04
• Updated: 16/Aug/22 13:46
• Resolved: 30/Nov/21 11:47

Description

As thin client protocol interprets first 4 bytes as message size and allocate array for it. Any "big" 4 bytes sent on thin client port could leads to OOM.

Some ideas to resolve:
 - print WARN in case of big client message
 - allocate array not for all message, but allocate it gradually.
 - read more then first4 bytes to understand is it real client message, or it is some trash.

Issue Links

• is related to: IGNITE-15925 Ignite 3: Make thin client protocol more robust
• links to: GitHub Pull Request #9610