[IGNITE-15688] IgniteClient.close shouldn't throw Exception

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.12
• Component/s: thin client
• Ignite Flags: Release Notes Required
• Assignee: Stanislav Lukyanov
• Reporter: Stanislav Lukyanov
• Reviewer: Igor Sapego
• Created: 06/Oct/21 09:40
• Updated: 13/Oct/21 20:32
• Resolved: 13/Oct/21 20:32

Description

IgniteClient interface currently doesn't override close() from AutoClosable. Because of that, it inherits `close() throws Exception` forcing all users to catch Exception when using IgniteClient.

 

In fact, this shouldn't be required. `TcpIgniteClient implements IgniteClient` currently throws Exception but it doesn't need to - its code doesn't throw any checked exceptions.

 

Proposal:

1. Add `@Overrides public void close()` with no `throws` to IgniteClient.
2. Remove `throws Exception` from `TcpIgniteClient::close`

Note: this change is fully backwards-compatible. It is legal to narrow the scope of `throws` in a new version of a method.

Issue Links

• links to: GitHub Pull Request #9475