[IGNITE-14428] Formalize the names of the metrics included in the metric registry.

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.11
• Labels: IEP-35
• Release Note: IO discovery metric names were changed to start with the metric registry name.
• Ignite Flags: Docs Required, Release Notes Required
• Assignee: Mikhail Petrov
• Reporter: Mikhail Petrov
• Created: 26/Mar/21 10:30
• Updated: 29/Jun/21 21:50
• Resolved: 13/Apr/21 06:12

Description

It's needed to refactor metric names to obey the global rule - all of them must start with name of the registry they belongs to. And add corresponding assertion.

The purpose of this change is to make all metrics that belongs to one MetricRegistry have the name that obeys mentioned above rule regardless how they were registered. It helps to use a consistent approach to work with all metrics.

The following metric names will be changed to obey this rule:

JoinedNodes -> io.discovery.JoinedNodes
LeftNodes -> io.discovery.LeftNodes
FailedNodes -> io.discovery.FailedNodes
PendingMessagesRegistered -> io.discovery.PendingMessagesRegistered
CommunicationErrors -> io.discovery.CommunicationErrors
CurrentTopologyVersion -> io.discovery.CurrentTopologyVersion

Issue Links

• fixes: IGNITE-14376 JmxMetricExporter fails to export discovery metrics
• links to: dev-list discussion
• links to: GitHub Pull Request #8937