[IGNITE-13906] Possible deadlock between methods from GridEncryptionManager

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.9
• Fix Version/s: 2.10
• Assignee: Mirza Aliev
• Reporter: Mirza Aliev
• Created: 24/Dec/20 17:39
• Updated: 21/Jan/21 18:49
• Resolved: 29/Dec/20 23:01

Description

It seems that GridEncryptionManager uses metaStorageMux and checkpointReadLock in an inconsistent way.

Sometimes, the implementation acquires the mutex fist and then checkpointReadLock, sometimes vice versa, which may lead to a deadlock.

Let's consider the following scenario:

Thread-1: removeGroupKey acquired metaStorageMux and trying to get checkpointReadLock (cannot proceed further because of checkpointer)

Therad-2: doChangeMasterKey acquired checkpointReadLock and trying to get metaStorageMux (cannot proceed further due to thread-1)

Checkpointer-thread: trying to acquire the write lock (cannot get the lock due to thread-2)

 

Possible solutuion: acquire metaStorageMux before checkpointReadLock in doChangeMasterKey method

 

 

Issue Links

• links to: PR