[IGNITE-13685] Flaky failure of transactional tests in "java thin client" suite

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.10
• Component/s: thin client
• Labels: MakeTeamcityGreenAgain
• Assignee: Aleksey Plekhanov
• Reporter: Aleksey Plekhanov
• Created: 06/Nov/20 22:17
• Updated: 08/Nov/20 19:09
• Resolved: 08/Nov/20 19:08

Description

FunctionalTest#testTransactions, FunctionalTest.testOptimitsticRepeatableReadUpdatesValue, and some other transactional tests are flaky on Team City. See history: https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_JavaThinClient&tab=buildTypeHistoryList&branch_IgniteTests24Java8=%3Cdefault%3E
Root cause: get() method on ForkJoinTask sometimes can help with the execution of the task in common ForkJoinPool, so task is executed in the current thread, that already holds a transaction, and cache.get() method returns a value relative to this transaction.
See sack trace:

java.util.concurrent.ExecutionException: org.junit.ComparisonFailure: expected:<value[0]> but was:<value[1]>
  at java.base/java.util.concurrent.ForkJoinTask.get(ForkJoinTask.java:1006)
  at org.apache.ignite.client.FunctionalTest.testOptimitsticRepeatableReadUpdatesValue(FunctionalTest.java:719)
  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
  at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.base/java.lang.reflect.Method.invoke(Method.java:566)
  at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
  at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
  at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
  at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
  at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
  at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
  at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
  at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: org.junit.ComparisonFailure: expected:<value[0]> but was:<value[1]>
  at org.junit.Assert.assertEquals(Assert.java:115)
  at org.junit.Assert.assertEquals(Assert.java:144)
  at org.apache.ignite.client.FunctionalTest.lambda$testOptimitsticRepeatableReadUpdatesValue$10(FunctionalTest.java:712)
  at java.base/java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1407)
  at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
  at java.base/java.util.concurrent.ForkJoinTask.tryExternalHelp(ForkJoinTask.java:381)
  at java.base/java.util.concurrent.ForkJoinTask.externalInterruptibleAwaitDone(ForkJoinTask.java:351)
  at java.base/java.util.concurrent.ForkJoinTask.get(ForkJoinTask.java:1004)
  ... 13 more

Issue Links

• is caused by: IGNITE-13485 Java thin: increase test coverage for transactions and partition awareness
• links to: GitHub Pull Request #8436
• links to: TC thin client