[IGNITE-13284] Incorrect version check in GridDhtPartitionsReservation#release

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Ignite Flags: Docs Required, Release Notes Required
• Assignee: Unassigned
• Reporter: Alexey Scherbakov
• Created: 22/Jul/20 09:50
• Updated: 25/Jan/21 16:30

Description

Currently GridDhtPartitionsReservation holds a last server topology version, but compares it with a current version in reserve, causing unnecessary eviction attempts.

The fix looks easy:

/**
     * Releases all the registered partitions.
     */
    @Override public void release() {
        for (;;) {
            int r = reservations.get();

            if (r <= 0)
                throw new IllegalStateException("Method 'reserve' must be called before 'release'.");

            if (reservations.compareAndSet(r, r - 1)) {
                // If it was the last reservation and topology version changed -> attempt to evict partitions.
                if (r == 1 && !cctx.kernalContext().isStopping() &&
                    !topVer.equals(cctx.shared().exchange().lastAffinityChangedTopologyVersion(cctx.topology().readyTopologyVersion())))
                    tryEvict(parts.get());

                return;
            }
        }
    }