[IGNITE-13104] Spring data 2.0 IgniteRepositoryImpl#deleteAllById contains wrong code

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.8.1
• Fix Version/s: 2.9
• Component/s: springdata
• Release Note: Fixed incorrect processing of non-comparable keys in spring-data for repository methods: findAllById(ids) and deleteAllById(ids).
• Ignite Flags: Release Notes Required
• Assignee: Alexey Kuznetsov
• Reporter: Alexey Kuznetsov
• Created: 01/Jun/20 16:12
• Updated: 17/Jun/20 05:04
• Resolved: 05/Jun/20 14:27

Description

    /** {@inheritDoc} */
    @Override public void deleteAllById(Iterable<ID> ids) {
        if (ids instanceof Set)
            cache.removeAll((Set<ID>)ids);

        if (ids instanceof Collection)
            cache.removeAll(new HashSet<>((Collection<ID>)ids));

        TreeSet<ID> keys = new TreeSet<>();

        for (ID id : ids)
            keys.add(id);

        cache.removeAll(keys);
    }

As you can see cache.removeAll may be executed THREE times in some situations.
Also this method can throw ClassCast exception if ids collection contains objects that are not implement Comparable interface.

Issue Links

• links to: GitHub Pull Request #7886