Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-12767

MetricRegistryMBean is not thread safe

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: 2.8.1
    • Component/s: None
    • Labels:

      Description

      MetricRegistryMBean is not thread safe due to usage of histogramNames instance of HashMap class. Changing HashMap to ConcurrentHashMap will not help a lot (likely) because method MetricUtils.histogramBucketNames() uses just put method (putIfAbsent will help I believe).

      OpenCensusExporterSpi uses the same MetricUtils.histogramBucketNames() method. But it isn't issue for this exporter because it is single threaded.

      Also MetricUtils.histogramBucketNames() method is responsible for histogram bucket's name representation. I believe that it is responsibility of metric exporter and this method should be removed from MetricUtils.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                nizhikov Nikolay Izhikov
                Reporter:
                agura Andrey N. Gura
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: