[IGNITE-12767] MetricRegistryMBean is not thread safe

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Fix Version/s: 2.8.1
• Labels: IEP-35
• Assignee: Nikolay Izhikov
• Reporter: Andrey N. Gura
• Created: 10/Mar/20 16:01
• Updated: 01/Apr/20 15:42
• Resolved: 01/Apr/20 15:42

Description

MetricRegistryMBean is not thread safe due to usage of histogramNames instance of HashMap class. Changing HashMap to ConcurrentHashMap will not help a lot (likely) because method MetricUtils.histogramBucketNames() uses just put method (putIfAbsent will help I believe).

OpenCensusExporterSpi uses the same MetricUtils.histogramBucketNames() method. But it isn't issue for this exporter because it is single threaded.

Also MetricUtils.histogramBucketNames() method is responsible for histogram bucket's name representation. I believe that it is responsibility of metric exporter and this method should be removed from MetricUtils.

Issue Links

• is caused by: IGNITE-12044 [IEP-35] JmxExporterSpi displays histogram values incorrectly
• is fixed by: IGNITE-12769 MetricRegistryMBean and OpenCensusExporterSpi have memory leak