[IGNITE-12721] Validation of key length written to Distributed Metastorage

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Fix Version/s: 2.9
• Component/s: persistence
• Release Note: Issue is irrelevant because IGNITE-12726 is already fixed.
• Ignite Flags: Docs Required, Release Notes Required
• Assignee: Sergey Chugunov
• Reporter: Sergey Chugunov
• Created: 27/Feb/20 12:14
• Updated: 13/Apr/20 13:49
• Resolved: 13/Apr/20 13:40

Description

DistributedMetastorage functionality introduced in IGNITE-10640 provides convenient way to perform coordinated writes to local MetaStorages on all server nodes but lacks important part: validation of key length.

Current implementation of MetaStorage doesn't allow keys longer than a specific value (64 bytes minus some prefixes, see source code for details) and throws assertion error on an attempt to write longer key.

This error from MetaStorage is not propagated to DistributedMetastorage and (in theory) may even cause a node to halt.

In order to avoid this situation validation of key length should be added right to DistributedMetastorage implementation to enforce "fail-fast" principle and preserve Ignite nodes from potentially dangerous consequences.

Issue Links

• is related to: IGNITE-12726 Support long keys in DistributedMetaStorage.
• links to: GitHub Pull Request #7478