[IGNITE-12444] SQL: Query reduce can fail with NPE on retry.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.7.6
• Fix Version/s: 2.9, 2.8.1
• Component/s: sql
• Assignee: Andrey Mashenkov
• Reporter: Andrey Mashenkov
• Reviewer: Ivan Pavlukhin
• Created: 13/Dec/19 13:09
• Updated: 21/Apr/20 09:37
• Resolved: 16/Dec/19 12:11

Description

GridReduceQueryExecutor can fail with NPE on retry if it couldn't map during retry timeout.
So, 'lastRun' can be null here

   if (attempt > 0 && retryTimeout > 0 && (U.currentTimeMillis() - startTime > retryTimeout)) {
                UUID retryNodeId = lastRun.retryNodeId();
                String retryCause = lastRun.retryCause();

                assert !F.isEmpty(retryCause);

Also assertion above is not correct.
It is possible, we failed to send request, then retried with success to remap.
So, 'lastRun' would be not null, but cause is empty.

Issue Links

• links to: GitHub Pull Request #7138