[IGNITE-12305] Extend test coverage [IGNITE-11959] NullPointerException If transaction failed and failure handler doesn't configured explicitly

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8
• Assignee: Kirill Tkalenko
• Reporter: Kirill Tkalenko
• Reviewer: Alexander Lapin
• Created: 21/Oct/19 12:23
• Updated: 23/Oct/19 07:45
• Resolved: 23/Oct/19 07:45

Description

Test 1. No FH and checking trace of transaction

org.apache.ignite.internal.processors.cache.SafeLogTxFinishErrorTest#testSafeLogTxFinishErrorWithoutFailureHandler{quote}

1. Start cluster with no FH, load data, start transaction, start and call {
   Unknown macro: {activeTx.logTxFinishErrorSafe}

   }

2. Assert that log information doesn’t contains information about FH and no NPE occurs
3. Assert that message starts with Failed completing the transaction: [commit=%s, tx= and tx_id is correct.

Test 2: FH and checking trace of transaction

org.apache.ignite.internal.processors.cache.SafeLogTxFinishErrorTest#testSafeLogTxFinishErrorWithFailureHandler{quote}

1. Start cluster with FH, load data, start transaction, start and call {
   Unknown macro: {activeTx.logTxFinishErrorSafe}

   }

2. Assert that log information doesn’t contains information about FH and no NPE occurs
3. Assert that message starts with Failed completing the transaction: [commit=%s, tx= and tx_id is correct.

Test 3: Failed String.format calling from tx

org.apache.ignite.internal.processors.cache.SafeLogTxFinishErrorTest#testSafeLogTxFinishErrorWithFailureHandlerAndRemoveTxState{quote}

1. Start cluster with FH, load data, start transaction with txState=null, start and call {
   Unknown macro: {activeTx.logTxFinishErrorSafe}

   }

2. Assert that log information doesn’t contains information about FH and no NPE occurs
3. Assert that message starts with Failed completing the transaction: [commit=%s, tx= and tx_id is correct.

 

Issue Links

• is related to: IGNITE-11959 NullPointerException If transaction failed and failure handler doesn't configured explicitly
• links to: GitHub Pull Request #6993