Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-12256

Fix double invocation of javaMajorVersion in scripts

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.7.6
    • 2.8
    • general
    • None

    Description

      Most of our shell script look as folows:

      #
      # Discover path to Java executable and check it's version.
      #
      checkJava
      
      #
      # Discover IGNITE_HOME environment variable.
      #
      setIgniteHome
      
      #
      # Final JVM_OPTS for Java 9+ compatibility
      #
      javaMajorVersion "${JAVA_HOME}/bin/java"
      

      It makes no sense to me since we already call javaMajorVersion in checkJava. Let's try to get rid of it.

      Attachments

        Issue Links

          Activity

            People

              ilyak Ilya Kasnacheev
              ilyak Ilya Kasnacheev
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m