Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-11815

Get rid of GridTestUtils.retryAssert method.

    XMLWordPrintableJSON

Details

    • Test
    • Status: Patch Available
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • None

    Description

      For now we have GridTestUtils.retryAssert() method which runs a closure 'n' times to check if some invariantes become ok, eventually.

      This method catch assertion error (this looks like a very bad idea) and can print them to log many times even if assertion is acceptable for the moment.
      Also, it is possible to miss an assertion is not related to those ones that closure checks  (e.g. assertion error thrown from ignite internals).

      Let's replace retryAssert with GridTestUtils.waitForCondition() usage to make logs clearer and to avoid possible false positive results.

      Attachments

        Issue Links

          Activity

            People

              Diana Diana Iakovleva
              amashenkov Andrey Mashenkov
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 50m
                  1h 50m