[IGNITE-11323] Reduce boilerplate "System.setProperty" code in tests

• Type: Test
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8
• Labels: MakeTeamcityGreenAgain
• Assignee: Ivan Bessonov
• Reporter: Ivan Bessonov
• Created: 14/Feb/19 15:26
• Updated: 18/Mar/19 12:01
• Resolved: 15/Mar/19 11:29

Description

There are many examples in tests where some property gets new value in "beforeTestsStarted"/"beforeTest"/"beginning of test method" and then gets its previous value in "afterTestsStopped"/"afterTest"/"finally block of test method". This approach leads to excessive code that can be avoided.

I suggest implementing annotation "WithSystemProperty" (name is the subject to discussion) that will allow us to write this:

@Test
@WithSystemProperty(key = IGNITE_SKIP_CONFIGURATION_CONSISTENCY_CHECK, value = "true")
public void testSkipCheckConsistencyFlagEnabled() throws Exception {
    ...
}

instead of this:

@Test
public void testSkipCheckConsistencyFlagEnabled() throws Exception {
    String backup = System.setProperty(IGNITE_SKIP_CONFIGURATION_CONSISTENCY_CHECK, "true");

    try {
        ...
    }
    finally {
        if (backup != null)
            System.setProperty(IGNITE_SKIP_CONFIGURATION_CONSISTENCY_CHECK, backup);
        else
            System.clearProperty(IGNITE_SKIP_CONFIGURATION_CONSISTENCY_CHECK);
    }
}

 

There also has to be ability to use this annotation on test class so new value of system properties will be used in all of its test methods.

Issue Links

• is required by: IGNITE-11560 @WithSystemProperty annotation breaks some existing tests.
• links to: GitHub Pull Request #6109