Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-10808

Discovery message queue may build up with TcpDiscoveryMetricsUpdateMessage

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.7
    • 2.8
    • None
    • Docs Required

    Description

      A node receives a new metrics update message every `metricsUpdateFrequency` milliseconds, and the message will be put at the top of the queue (because it is a high priority message).
      If processing one message takes more than `metricsUpdateFrequency` then multiple `TcpDiscoveryMetricsUpdateMessage` will be in the queue. A long enough delay (e.g. caused by a network glitch or GC) may lead to the queue building up tens of metrics update messages which are essentially useless to be processed. Finally, if processing a message on average takes a little more than `metricsUpdateFrequency` (even for a relatively short period of time, say, for a minute due to network issues) then the message worker will end up processing only the metrics updates and the cluster will essentially hang.

      Reproducer is attached. In the test, the queue first builds up and then very slowly being teared down, causing "Failed to wait for PME" messages.

      Need to change ServerImpl's SocketReader not to put another metrics update message to the top of the queue if it already has one (or replace the one at the top with new one).

      Attachments

        1. IgniteMetricsOverflowTest.java
          4 kB
          Stanislav Lukyanov

        Activity

          People

            dmekhanikov Denis Mekhanikov
            slukyanov Stanislav Lukyanov
            Sergey Chugunov Sergey Chugunov
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 10m
                10m