[IBATISNET-283] Result mappings should work with interfaces when QueryForObject is passed an existing object

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: DataMapper 1.6.1
• Fix Version/s: DataMapper 1.6.2, DataMapper 3.0
• Component/s: DataMapper
• Assignee: Gilles Bayon
• Reporter: Richard Banks
• Created: 07/Oct/08 07:56
• Updated: 11/Oct/08 21:27
• Resolved: 11/Oct/08 21:27

Description

In the IBatisNet.DataMapper.DataExchange.DotNetObjectDataExchange class the method public override void SetData(ref object target, ResultProperty mapping, object dataBaseValue)
does a check against types using this statement:

if ((type != this._parameterClass) && !type.IsSubclassOf(this._parameterClass))

The problem here is that IsSubclassOf doesn't check for interface implementations. When _parameterClass is an interface you also need to check using

type.GetInterfaces().Contains(this._parameterClass)

This would then allow for result mappings to use interfaces, which is really useful when you are using an IoC container to instantiate the class being populated, for example:

ISale sale = Container.Resolve<ISale>();
...
Mapper.Instance().QueryForObject<ISale>("uspSelectSale", saleNumber, sale);

Thanks