[HUDI-2573] Deadlock w/ multi writer due to double locking

• Type: Task
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 0.10.0
• Labels: pull-request-available release-blocker sev:critical
• Epic Link: Metadata Table for File Listing & Query Planning
• Assignee: sivabalan narayanan
• Reporter: sivabalan narayanan
• Created: 18/Oct/21 14:29
• Updated: 04/Jan/22 00:09
• Resolved: 29/Oct/21 18:55

Description

With synchronous metadata patch, we added locking for cleaning and rollbacks. but there are code paths, where we do double locking and hence it hangs or fails after sometime.

 

inline cleaning enabled.

 

C1 acquires lock. 

    post commit -> triggers cleaning. 

                      cleaning again tries to acquire lock when about to commit and this is problematic.

 

Also, when upgrade is needed, we take a lock and rollback failed writes. this again will run into issues w/ double locking. 

 

 

                      

Issue Links

• links to: GitHub Pull Request #3827