[HTTPCORE-679] URIBuilder in 5.1 encodes more characters than necessary

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Invalid
• Affects Version/s: 5.1
• Component/s: HttpCore
• Assignee: Unassigned
• Reporter: Siqi Li
• Created: 09/Jun/21 20:30
• Updated: 10/Jun/21 14:15
• Resolved: 09/Jun/21 22:11

Description

Take this simple code example:

System.out.println(new URIBuilder().setScheme("https").setHost("example.com").setPathSegments("foo:bar").toString());

In 5.0 and in 4.x, this code would produce 

https://example.com/foo:bar

Since 5.1, the behavior has changed. It now produces

https://example.com/foo%3Abar

This actually broke one of my calls to iap.googleapis.com. I know it can be argued that it's the server's fault for not decoding %3A, but ':' does not actually need to be encoded in URL path segments. Also, this is an unnecessary breaking change in URIBuilder's behavior.