[HTTPCORE-649] Implement ByteArrayBuffer.append(ByteBuffer)

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.1-beta1
• Component/s: HttpCore
• Assignee: Carter Kozak
• Reporter: Carter Kozak
• Created: 27/Aug/20 16:41
• Updated: 14/Sep/20 15:16
• Resolved: 28/Aug/20 12:07

Description

This is an additive api change to a final class, possibly for 5.1 instead of 5.0.x.

We append lots of ByteBuffer objects into ByteArrayBuffers, this can be a little tricky and easy to get subtly wrong (see HTTPCORE-648, HTTPCLIENT-2112). This will be easier to support over time if we consolidate the implementation into ByteArrayBuffer.