[HTTPCORE-639] Add a configurable ResponseOutOfOrder strategy for DefaultBHttpClientConnection

• Type: New Feature
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.1-beta1
• Component/s: HttpCore
• Assignee: Michael Osipov
• Reporter: Carter Kozak
• Created: 21/Jul/20 19:01
• Updated: 14/Sep/20 15:16
• Resolved: 05/Aug/20 08:21

Description

In a known environment where the server fully reads full request bodies before sending a response, I would like to disable the expensive checkForEarlyResponse checks implemented by DefaultBHttpClientConnection.sendRequestEntity.

Using TLS the check blocks for 1ms every 8kb, which limits the upload rate to at most eight megabytes per second, relatively low in a data-center environment.

Proposed interface:

public interface ResponseOutOfOrderStrategy {

    /**
     * Returns the interval in bytes describing how often the socket is checked for an out-of-order response.
     * The default implementation uses 8kb. A value of zero results in checks being disabled, this may result
     * in requests blocking until the socket timeout is reached while a server sends an out-of-order response.
     */
    int determineResponseCheckIntervalBytes(ClassicHttpRequest request, Socket socket);
}

I'd be happy to implement and contribute such a feature if you agree that it's reasonable.

I appreciate any input and feedback you can provide!