[HTTPCORE-571] SSLSocket input / output closing causes issues with TLSv1.3 SSLEngine

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 4.4.11
• Component/s: HttpCore
• External issue URL: https://github.com/elastic/elasticsearch/issues/38646
• Assignee: Unassigned
• Reporter: Jay Modi
• Created: 08/Feb/19 20:25
• Updated: 12/Feb/19 16:12
• Resolved: 12/Feb/19 16:12

Description

I've been doing some testing with TLSv1.3 and came across some interesting behavior in the OpenJDK SSLEngine running in server mode and being accessed with HttpClient. The server side winds up in a loop trying to wrap data to send the close. I tracked down the trigger for the issue to the shutdown of the input and output on the socket manually before closing. I'll also be reporting this on the OpenJDK mailing list as that's where the real issue is.

 

However, I'm wondering if as an improvement the close() method of BHttpConnectionBase could special case SSLSocket? I came across HTTPCORE-22, which mentions that this would throw an UnsupportedOperationException in some JDKs when used with a SSLSocket, so maybe just doing an instanceof check and calling close() if it is an SSLSocket might be best?