[HTTPCORE-518] Improve buffer allocation

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Won't Fix
• Component/s: HttpCore NIO
• Assignee: Unassigned
• Reporter: Ion Moldovan
• Created: 16/Mar/18 15:51
• Updated: 12/Feb/19 09:25
• Resolved: 12/Feb/19 09:25

Description

The doubling of the buffer size every time it exceeds its previous size is a good way for small buffers, but quite wasteful for large sizes.

A more modest growth (e.g. 1.25 x Previous Size)  when sizes are > 32MB would be a nice improvement.

Proposed solution:

/**
* Expands buffer's capacity.
*
* @throws BufferOverflowException in case we get over the maximum allowed value
*/
protected void expand() throws BufferOverflowException {
  int newcapacity;
  if (this.buffer.capacity() <= (32 << 20) ) {
    newcapacity = (this.buffer.capacity() + 1) << 1;
  } else {
    newcapacity = (this.buffer.capacity() + 1) * 5 / 4;
  }
...
}

 What do you think?