[HTTPCORE-501] org.apache.hc.core5.net.URLEncodedUtils.parse() should return a new ArrayList when there are no query parameters

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.0-beta1
• Fix Version/s: 5.0-beta2
• Component/s: HttpCore
• Assignee: Gary D. Gregory
• Reporter: Gary D. Gregory
• Created: 15/Dec/17 21:20
• Updated: 15/Dec/17 21:24
• Resolved: 15/Dec/17 21:24

Description

org.apache.http.client.utils.URLEncodedUtils.parse(URI, Charset) should return a new ArrayList when there are no query parameters.

Currently, org.apache.http.client.utils.URLEncodedUtils.parse(URI, Charset) returns an immutable list through Collections.emptyList() if there are no params> But if there are parameters, the method returns a mutable list.

This makes it impossible to write the same code to handle both cases.

This change will cause the method to return a new ArrayList if there are no parameters.

The methods that are directly affected are:

• org.apache.hc.core5.net.URLEncodedUtils.parse(String, Charset, char...)
• org.apache.hc.core5.net.URLEncodedUtils.parse(String, Charset)
• org.apache.hc.core5.net.URLEncodedUtils.parse(URI, Charset)

Issue Links

• is a clone of: HTTPCLIENT-1889 org.apache.http.client.utils.URLEncodedUtils.parse() should return a new ArrayList when there are no query parameters