Uploaded image for project: 'HttpComponents HttpCore'
  1. HttpComponents HttpCore
  2. HTTPCORE-433

Setting validateAfterInactivity to 1ms increases lock contention in AbstractConnPool

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 4.4.4
    • 4.4.6
    • HttpCore
    • None

    Description

      This issue was observed after upgrading to httpclient v4.5.2 and httpcore v4.4.4.

      When configuring the PoolingHttpClientConnectionManager, I have set validateAfterInactivity to 1ms as this is the only way of maintaining the old behaviour, i.e. checking every connection if is stale before using it.

      I have observed a performance degradation under high load when the httpclient is shared between multiple threads. This httpclient is used only for one route.

      After taking a thread dump, one thing that got my attention was several threads waiting for same ReentrantLock instance while trying to AbstractConnPool#getPoolEntryBlocking/AbstractConnPool#release. The ReentrantLock instance in question was owned by another thread performing CPool#validate.

      It seems to me that performing this stale check inside the region protected by this lock is unnecessary and also induces a big performance hit when using the httpclient from multiple threads.

      I've atached a thread dump of a test application that reproduces this behaviour. ReentrantLock in question in this thread dump is 0x0000000706e8b9a8 and is owned by Thread-4.

      Attachments

        1. httpclient_thread_dump
          32 kB
          Sergiu Prodan
        2. threads_when_inactivity_set_to_1.png
          48 kB
          Sergiu Prodan
        3. threads_when_inactivity_set_to_2000.png
          47 kB
          Sergiu Prodan

        Activity

          People

            Unassigned Unassigned
            sergiuprodan Sergiu Prodan
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: