[HTTPCLIENT-2333] A request retry upon redirect is incorrectly flagged as a circular redirect

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.3.1
• Fix Version/s: 5.4
• Component/s: HttpClient (async), HttpClient (classic)
• Assignee: Unassigned
• Reporter: Teresa Tang
• Created: 22/Jul/24 20:16
• Updated: 22/Sep/24 09:11
• Resolved: 05/Aug/24 15:00

Description

When a request is redirected and then needs to be retried, the retry is treated as a circular redirect. If circular redirects are not allowed, an error is thrown:

 

org.apache.hc.client5.http.ClientProtocolException: Circular redirect to 'http://localhost:35731/random/50'    at org.apache.hc.client5.http.impl.classic.InternalHttpClient.doExecute(InternalHttpClient.java:173)
    at org.apache.hc.client5.http.impl.classic.CloseableHttpClient.execute(CloseableHttpClient.java:245)
    at org.apache.hc.client5.testing.sync.TestRedirects.testRetryUponRedirect(TestRedirects.java:241)
    at java.base/java.lang.reflect.Method.invoke(Method.java:580)
    at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
    at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
    at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: org.apache.hc.client5.http.CircularRedirectException: Circular redirect to 'http://localhost:35731/random/50'
    at org.apache.hc.client5.http.impl.classic.RedirectExec.execute(RedirectExec.java:144)
    at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
    at org.apache.hc.client5.http.impl.classic.InternalHttpClient.doExecute(InternalHttpClient.java:170)
    ... 6 more

 

Please see testRetryUponRedirect in TestRedirects.java for an example. NullHandler.java will return a bad response only for the first redirected request (files attached)