[HTTPCLIENT-2098] maxResultLength parameter no effect on reading HttpEntity

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.0.1
• Fix Version/s: 5.0.2
• Component/s: HttpClient (classic)
• Labels: security
• Flags: Important
• Assignee: Unassigned
• Reporter: Andriy
• Created: 08/Jul/20 16:24
• Updated: 10/Jul/20 08:37
• Resolved: 10/Jul/20 08:37

Description

maxResultEffect seems to have no effect on the org.apache.hc.core5.http.io.entity.EntityUtils#toByteArray(org.apache.hc.core5.http.HttpEntity, int) method.

https://github.com/apache/httpcomponents-core/blob/5.1.x/httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/EntityUtils.java#L149

 

Test (passing) to reproduce the error:

@Test
public void testMaxResultLengthNoEffect() throws IOException {
    String random = org.apache.commons.lang3.RandomStringUtils.random(5000, true, true);
    byte[] bytes = org.apache.hc.core5.http.io.entity.EntityUtils.toByteArray(
            new org.apache.hc.core5.http.io.entity.StringEntity(random)
            , (int) Math.pow(10, 3));
    String s = new String(bytes);
    Assert.assertEquals(random,s);
}