Uploaded image for project: 'HttpComponents HttpClient'
  1. HttpComponents HttpClient
  2. HTTPCLIENT-2095

Consider replacing concatenation into slf4j loggers with interpolation

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.0.1
    • Fix Version/s: 5.0.2
    • Component/s: HttpCache
    • Labels:
      None

      Description

      In most cases these statements are protected by a conditional to check if the logger is enabled so there shouldn't be a real performance impact, replacing concatenation would result in code aligned with modern logging recommendations, and improve perf in a few cases that aren't guarded (though at a glance I don't see any in hot paths).

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              ckozak Carter Kozak
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 2h 50m
                2h 50m