[HTTPCLIENT-2094] setValidateAfterInactivity disagreement between classic/async for duration zero

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.0.1
• Fix Version/s: 5.0.2
• Component/s: Documentation, HttpClient (async), HttpClient (classic)
• Assignee: Unassigned
• Reporter: Carter Kozak
• Created: 01/Jul/20 17:43
• Updated: 11/Jul/20 15:38
• Resolved: 02/Jul/20 09:30

Description

Pooling(Async|Http)ClientCOnnectionManager.setValidateAfterInactivity documentation says that non-positive values result in no validation.
This is true of the asynchronous implementation, however the classic implementation only uses negative values to disable validation where zero results in validation prior to each request.

Ideally the semantics would match between the two connection managers. My preference would be to update the documentation in both and the implementation of the asynchronous manager so that zero always validates connections for behavior similar to okhttp (while certainly not a good idea in most cases, has benefits in environments with poor connectivity). This approach would also match behavior of 4.x.

Thoughts?