[HTTPCLIENT-2028] Restore staleConnectionCheckEnabled=true semantic behavior in validateAfterInactivity config

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 4.5, 4.5.1, 4.5.2, 4.5.3, 4.5.4, 4.5.5, 4.5.6, 4.5.7, 4.5.8, 4.5.9, 4.5.10
• Component/s: HttpClient (classic)
• Assignee: Unassigned
• Reporter: Peter Frank
• Created: 07/Nov/19 21:41
• Updated: 22/Nov/19 21:36
• Resolved: 10/Nov/19 14:22

Description

Between HttpClient 4.4.x and 4.5.x setStaleConnectionCheckEnabled was deprecated in favor of setValidateAfterInactivity.  That's all fine, however, the implementation of setValidateAfterInactivity has no ability to check if a connection is stale all the time.  The closest one can get is 1 ms, and that's unfortunately not short enough in a test environment scenario when a test Http Server is being restarted between Tests to clear out state.

This is a common issue on the internet for people that use something like Wiremock, the irony is troubleshooting the situation makes it go away (cause logging slows the tests).

I would suggest making 0 a special value to "turn on" validation all the time.

With HttpClient 5 removing the old staleConnectionCheckEnabled completely with a piece of what that feature actually did also being removed I fear it will leave me, and perhaps others, in a bit of a lurch.  Thanks!

Issue Links

• depends upon: HTTPCORE-613 Add staleConnectionCheckEnabled=true semantic behavior in validateAfterInactivity config
• duplicates: HTTPCORE-613 Add staleConnectionCheckEnabled=true semantic behavior in validateAfterInactivity config
• links to: GitHub Pull Request #175