Uploaded image for project: 'HttpComponents HttpClient'
  1. HttpComponents HttpClient
  2. HTTPCLIENT-1983

URIBuilder normalization change is significantly breaking

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 4.5.7, 4.5.8
    • Fix Version/s: 4.5.9
    • Component/s: None
    • Labels:
      None

      Description

      In 4.5.7, the behavior of URIBuilder changed in order to address HTTPCLIENT-1960. Since that version was released, I have seen a concerning number of users complain that this change has broken their code (see issue links). In 4.5.8, as a result of HTTPCLIENT-1968, an option was added to allow users to opt in to the old behavior, but the new behavior is what they will get by default. This problem is difficult to work around for developers who cannot exercise exact control over the runtime version of HttpClient: the method they need might not be there, and if it is, it needs to be invoked reflectively, or in a way that tolerates a NoSuchMethodError.

      For the sake of compatibility, I propose that we change the default value of normalizeUri to false. This will be the default on the 4.5.x line only; the 5.0.x line, as well as any future 4.6.x line, will normalize by default (if an option is needed at all).

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                rschmitt Ryan Schmitt
              • Votes:
                2 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m