[HTTPCLIENT-1968] Encoded forward slashes are not preserved when rewriting URI

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.5.7
• Fix Version/s: 4.5.8, 5.0 Beta4
• Flags: Patch
• Assignee: Unassigned
• Reporter: Jay Modi
• Created: 29/Jan/19 19:58
• Updated: 03/Nov/19 20:26
• Resolved: 19/Feb/19 08:29

Description

URIs that contain an encoded forward slash (%2F) are no longer preserved when the HTTP client executes. I came across this when upgrading from 4.5.2 to 4.5.7 and my requests that contained an encoded forward slash suddenly started failing. The appears to be due to decoding and re-encoding of the path that takes place in the URIUtils#rewriteURI method. I've attached a patch that restores the old behavior but if a URI contains two slashes in a row in addition to an encoded slash the encoded forward slash will be decoded.

Issue Links

• causes: HTTPCLIENT-1983 URIBuilder normalization change is significantly breaking
• causes: KNOX-1755 Revert upgrade httpclient to 4.5.7 due to HTTPCLIENT-1968
• causes: CXF-7955 Update HttpComponents client to 4.5.8 and core 4.4.11
• is caused by: HTTPCLIENT-1960 URIBuilder incorrect handling of multiple leading slashes in path component
• is duplicated by: HTTPCLIENT-1975 Error handling double url-encoded forward slashes
• is related to: KNOX-1842 Upgrade httpclient to 4.5.10
• relates to: HTTPCLIENT-1984 Add normalize URI to RequestConfig copy constructor
• links to: GitHub Pull Request #136