[HTTPCLIENT-1960] URIBuilder incorrect handling of multiple leading slashes in path component

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.5.5
• Fix Version/s: 4.5.7, 5.0 Beta4
• Component/s: HttpClient (async), HttpClient (classic)
• Flags: Patch
• Assignee: Oleg Kalnichevski
• Reporter: Raymond Cuenen
• Created: 11/Jan/19 10:15
• Updated: 25/Jun/19 09:49
• Resolved: 14/Jan/19 10:08

Description

If original path startsWith '/' it is removed by normalizePath; in that case it should be added again URI-encoded. For example: A path value of '/etc/motd' becomes:

ftp://[e-mail]/etc/motd

while it should be:

ftp://[e-mail]/%2Fetc/motd

Only when the path value is 'etc/motd' is should become "ftp://[e-mail]/etc/motd"
 

Fix for this issue in URIBuilder.java:

private String buildString() {
...
    if (this.encodedPath != null) {
        sb.append(normalizePath(this.encodedPath, sb.length() == 0));
    } else if (this.path != null) {
        String encodedPath = encodePath(normalizePath(this.path, sb.length() == 0));
        // Start fix for paths starting with '/'
        // If original path startsWith '/' it is removed by normalizePath; in that case it should be added again URI-encoded.
        if (this.path.startsWith("/")) {
            encodedPath = "/%2F" + encodedPath.substring(1);
        }
        // End fix
        sb.append(encodedPath);
    }
...
}

Issue Links

• causes: HTTPCLIENT-1968 Encoded forward slashes are not preserved when rewriting URI
• causes: HTTPCLIENT-1983 URIBuilder normalization change is significantly breaking