[HTTPCLIENT-1865] DefaultServiceUnavailableRetryStrategy does not respect HttpEntity#isRepeatable

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.5.3
• Fix Version/s: 4.5.4
• Component/s: HttpClient (classic)
• Environment: Any environment
• Flags: Patch
• Assignee: Unassigned
• Reporter: Tomas Celaya
• Created: 31/Jul/17 17:53
• Updated: 01/Aug/17 17:28
• Resolved: 01/Aug/17 01:21

Description

The HttpEntity interface provides a method for indicating whether or not an entity can be automatically retried. While investigating an issue with corruption of encrypted uploads in the java-manta library I discovered that requests were being automatically retried in the event of a 503 response from the server. Stepping through the execution path led me to discover that ServiceUnavailableRetryExec does not check the supplied HttpRequest to determine whether or not it can be safely retried. We've implemented a fix within java-manta in our subcclass of DefaultServiceUnavailableRetryStrategy but this seems like it could bite others as well so I thought it would merit a bug report.

The included patch corrects this behavior. Checked that mvn verify completes successfully. Please let me know if there are any questions or other modifications that I need to make in order to contribute this patch.