[HTTPCLIENT-1725] Heuristic caching does not work for URIs with a query string

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.5.1
• Fix Version/s: 5.4-alpha1
• Component/s: HttpCache
• Labels: stuck volunteers-wanted
• Assignee: Unassigned
• Reporter: Charlie Halford
• Created: 29/Feb/16 17:31
• Updated: 21/Aug/23 08:54
• Resolved: 07/May/23 08:40

Description

When enabling heuristic caching and setting a default lifetime, the responses from the server I am requesting from are not being stored in the cache.

In org.apache.http.impl.client.cache.ResponseCachingPolicy, line 250 determines if the URI contains a query string:

request.getRequestLine().getUri().contains("?")

A few lines below, it then checks to see if the response contains cache headers:

else if (!isExplicitlyCacheable(response))

As I am attempting to cache a response that I know does not contain cache headers, the response should succeed in being cached. However, it fails the isExplictlyCachable() check, and thus returns false to the overall isResponseCachable() method. The isExplicitlyCachable() method is checked later on in the stack, so perhaps it can be safely removed here?