[HTTPCLIENT-1710] OSGiRoutePlanner examines only the first proxy exception and also crashes processing IP address exception

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.4.1, 4.5, 5.0
• Fix Version/s: 5.0 Alpha1
• Component/s: HttpClient (classic)
• Environment: OSGi
• Assignee: Unassigned
• Reporter: munene kiruja
• Created: 29/Dec/15 23:55
• Updated: 04/May/17 09:49
• Resolved: 02/Jan/16 14:25

Description

The HttpClientBuilderFactory and internal RoutePlanner objects are a fantastic addition since 4.3.

There are couple minor bugs rendering them unusable at the moment though.

1. The OSGiRoutePlanner.determinProxy() method only examines the first proxy exception.

2. When OSGiRoutePlanner.determinProxy() is creating a NetworkAddress from a String IP address, it refers to the 6th capture group in a case where there are only four, leading to an out of bounds exception.

The class file is attached containing fixes for both issues at the 4.4.1 version. I checked and found both issues existing in the trunk (5.0) at the time of this writing.

Issue Links

• is duplicated by: HTTPCLIENT-1791 Proxy exceptions not honoured in HttpClient-osgi module