[HTTPCLIENT-1246] Patch for JmxEnabledHttpClient

• Type: New Feature
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Component/s: HttpClient (classic)
• Assignee: Unassigned
• Reporter: Mike Boyers
• Created: 06/Oct/12 17:10
• Updated: 19/Feb/18 22:00
• Resolved: 27/Jul/15 16:19

Description

Oleg asked me to submit this patch via JIRA. This is an initial version of code to enable JMX for requests/timeouts/etc.

I've uploaded the patch as an attachment.

Here are my comments about what I have and have not done. This is from an email earlier in the week:

What I have at this point is a version of a JmxEnabledHttpClient that implements the HttpClient interface. You can instantiate a JmxEnabledHttpClient given an HttpClient. I have decoupled it from the work I had done previously (Spring-dependent), so it works without any additional dependencies. I probably just need a couple more hours to clean this area up. I did work on it a bit yesterday.

But I have not made progress in integrating the stats more closely with the HttpClient codebase. So it doesn't currently have visibility into some of the underlying behavior of HttpClient and some of the mechanisms for retaining and managing statistics could probably be done more cheaply if they were integrated more closely. This is the area I just don't think I'm going to be able to find the time to do, sadly.

So what I'm thinking at this point: I'll hand off what I've done (which is functional) and you guys can decide on whether or not to use it as the basis for anything going forward. Even if you decide not to ultimately check it in with the rest of the HttpClient code, it could still be useful to you in the short-term, as it could easily be turned into its own jar and used with the existing HttpClient. I'm pretty sure it records everything we talked about previous except the current pool size.

Issue Links

• is duplicated by: HTTPCLIENT-1222 Monitoring httpclient metrics via JMX