Thanks a lot Oleg Kalnichevski for reviewing my patch!
let's discuss points one by one:
(1) My understanding is that HttpClient OSGi bundle is dependent on HttpCore OSGi bundle and it is responsibility of HttpCore bundle to export core packages. Can this confusion be due to the fact that HttpClient OSGi does not correctly declare its dependency on HttpCore bundle?
Sorry, my bad - I didn't notice there is an HttpCore OSGi bundle, that makes my patch invalid - the right way should be importing in the OSGi runtime environment the HttpCore OSGi bundle first, then the HttpClient OSGi one.
I am honestly not a fan of declaring bundles dependencies in OSGi metadata, it is IMHO a nice workaround for particular situations - I'll make a test with the HttpCore bundle in my runtime and let you know
(2) HttpClients interface sounds like a misnomer to me. This looks more like HttpClientBuilderFactory. The name is uglier but more precise
Agreed, I didn't find a better name for that interface indeed and your feedback is much more than appreciated!
(3) Can we put something in the name of the new classes to stress out their purpose and make them more distinguishable? DefaultHttpRoutePlanner -> OSGiHttpRoutePlanner, DefaultCredentialsProvider -> OSGiCredentialsProvider?
Yes sure, I think so, even if, since they are already under osgi package, I was looking for a less redundant name, but having that taxonomy works for me
Shall I commit the patch as is or do you want to submit another patch?
I think it is reasonable I submit a new patch, applying your feedbacks
PS: I'd prefer be mentioned with the simone.tripodi id, simao is a mistake I was not able to delete