[HTTPCLIENT-1155] CachingHttpClient should have similar behavior as AbstractHttpClient when executing with ResponseHandler

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.1.2, 4.2 Beta1
• Fix Version/s: 4.1.3, 4.2 Beta1
• Component/s: HttpCache
• Labels: cache leak
• Assignee: Unassigned
• Reporter: James Miller
• Created: 22/Dec/11 14:31
• Updated: 05/Oct/13 19:41
• Resolved: 23/Dec/11 21:01

Description

When calling execute on the AbstractHttpClient with a ResponseHandler, the AbstractHttpClient will attempt to Consume the Entity and close any open connections before returning. This behavior is not currently in the CachingHttpClient.

This can lead to connection leaks when switching to CachingHttpClient, becuase the responsibility to fully consume the entity is now on the ResponseHandler instead on the HttpClient.

Here is the code that does the existing 'auto-close' behavior: "org.apache.http.impl.client.AbstractHttpClient.java" lines 1080-1111