Uploaded image for project: 'HttpComponents HttpClient'
  1. HttpComponents HttpClient
  2. HTTPCLIENT-1143

CachingHttpClient leaks connections with stale-if-error

    Details

      Description

      If you are using the "stale-if-error" Cache-control header and CachingHttpClient decides to use a stale cached response it does not clean up the existing backend response.

      This bug causes connections to leak from the connection pool each time the stale-if-error flow is executed.

        Activity

        Hide
        jonm Jon Moore added a comment -

        Patch applied and backported to 4.1.x release branch.

        Show
        jonm Jon Moore added a comment - Patch applied and backported to 4.1.x release branch.
        Hide
        jonm Jon Moore added a comment -

        Patch checked in to trunk with slight modifications, including unit test to reproduce. Thanks, James! I'll work on getting this ported to the release branches next.

        Show
        jonm Jon Moore added a comment - Patch checked in to trunk with slight modifications, including unit test to reproduce. Thanks, James! I'll work on getting this ported to the release branches next.
        Hide
        jonm Jon Moore added a comment -

        Hi James, thanks for finding this. I'm actually working on a unit test to reproduce, although I agree you've found a bug and your patch should address it. Just dotting all the i's, so to speak.

        Show
        jonm Jon Moore added a comment - Hi James, thanks for finding this. I'm actually working on a unit test to reproduce, although I agree you've found a bug and your patch should address it. Just dotting all the i's, so to speak.
        Hide
        millerjam James Miller added a comment -

        patch for stale-if-error connection leak

        Show
        millerjam James Miller added a comment - patch for stale-if-error connection leak

          People

          • Assignee:
            jonm Jon Moore
            Reporter:
            millerjam James Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development