[HTTPCLIENT-1136] BasicClientConnectionManager.releaseConnection accesses poolEntry using non-standard lock

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.2 Alpha1
• Component/s: HttpClient (classic)
• Assignee: Unassigned
• Reporter: Sebb
• Created: 11/Oct/11 15:12
• Updated: 05/Oct/13 19:42
• Resolved: 11/Oct/11 17:53

Description

According to the annotation, poolEntry is @GuardedBy("this").

However, in at least one place, it is accessed without holding a lock on this:

BasicClientConnectionManager.releaseConnection synchronizes on managedConn, and then accesses poolEntry without synchronising on this.

[Synch. only works if all parties use the same lock.]