[HTTPCLIENT-1116] ResponseCachingPolicy uses integers for sizes

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.1.1
• Fix Version/s: 4.2 Alpha1
• Component/s: HttpCache
• Labels: cache policy
• Assignee: Unassigned
• Reporter: Greg Bowyer
• Created: 12/Aug/11 20:42
• Updated: 05/Oct/13 19:41
• Resolved: 18/Sep/11 16:33

Description

ResponseCachingPolicy currently uses integers for interpreting the size of Content-Length, as well internally.

This causes issues in attempting to use the module for caching entities that are over 2GB in size, the module does not fail gracefully, but throws a NumberFormatException

I have a patch that fixes this, by promoting the int -> long, which should allow for larger entities to be cached, it also updates the public facing API where possible, I don't think that the promotion should break compatibility massively

The changes can also be seen here:
https://github.com/GregBowyer/httpclient/commit/1197d3f94bd2eedcec32646cd6146748ca2e6fa1