[HTTPCLIENT-1099] Overriding Caching Policies

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: 4.1.1
• Component/s: HttpCache
• Labels: cache policy stuck volunteers-wanted
• Assignee: Jonathan Moore
• Reporter: Bart Robeyns
• Created: 07/Jun/11 10:55
• Updated: 13/Jan/24 12:41
• Resolved: 13/Jan/24 12:41

Description

It is not possible to alter the behaviour of the CachingHttpClient because the policies defining the behaviour are private and tied directly to specific implementations in the CachingHttpClients constructor. Furthermore, these policies are package private, discouraging reuse and/or extensions.

Making this possible is easy enough (provide some policy-setters or -constructor-args in CachingHttpClient and make the policy-classes public); the attached patch allows custom Policies, extending the default ones to be set on the CacheConfig class.

The specific case that led to this question:

A back-end application only sets its Content-Length header for responses below 8K. This response does get stored in the cache, but when retrieving it from the cache, CacheValidityPolicy.contentLengthHeaderMatchesActualLength checks the Content-Length header with the stored size (to verify whether the cached content is complete). This check fails, causing the cache entry to be deemed unusable. If we were able to provide our own subclassed CacheValidityPolicy, it would be easy to skip the check if the header is missing and thus accomodate this specific back-end quirk.